fix: private members can override public members #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 91.96% 91.37% -0.60%
==========================================
Files 147 162 +15
Lines 4656 5496 +840
Branches 588 696 +108
==========================================
+ Hits 4282 5022 +740
- Misses 254 325 +71
- Partials 120 149 +29
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TimothyMakkison
force-pushed
the
priv_521
branch
2 times, most recently
from
de10dc1
to
77b05a7
Compare
|
@TimothyMakkison thank you for this test, could you rebase? |
TimothyMakkison
force-pushed
the
priv_521
branch
from
77b05a7
to
2bbc24d
Compare
latonz
approved these changes
Jul 12, 2023
|
🎉 This PR is included in version 2.9.0-next.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private members with greater flattening priority can override public members
Description
Under specific circumstances, when Mapperly attempts to map to a target, a private source members with greater flattening priority can override another public member. A later validation check would reject the mapping as the source is inaccessible, emitting a diagnostic.
#537 prevents this by only mapping accessable source members.
This PR contains a test to validate that the bug is fixed.
Fixes #521
Checklist