chore: common linq loop allocations, add small optimisations #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove linq allocations, add small optimisations
Description
Slightly microbenchmarky improvements, not sure about the manual foreach loops
FirstOrDefault
allocation fromSymbolExtensions.ImplementsGeneric
- 106KB -Func<INamedTypeSymbol, Boolean>
Where
allocation fromSymbolAccessor.GetMappableMembers
- 76KB -Func<ISymbol, Boolean>
Where
allocation fromSymbolAccessor.GetAttributes
- 150KB -Func<AttributeData, Boolean>
NonNullableValueType
checkIsRefLike
check toGetEnumeratedType
types.Get<int>()
call fromCollectionInfoBuilder.FindCountProperty
Related to #530
Benchmarks
200 KB saved, little change in speed.
Original
Changes
Checklist