chore: minor refactor for GetAttributes and UserMethods
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMakkison
force-pushed
the
minor_opt_refactor
branch
from
1ffb2f7
to
9ef7fd5
Compare
TimothyMakkison
force-pushed
the
minor_opt_refactor
branch
from
9ef7fd5
to
bcc710a
Compare
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 91.96% 91.37% -0.60%
==========================================
Files 147 162 +15
Lines 4656 5517 +861
Branches 588 702 +114
==========================================
+ Hits 4282 5041 +759
- Misses 254 326 +72
- Partials 120 150 +30
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
latonz
approved these changes
Jul 14, 2023
|
🎉 This PR is included in version 2.9.0-next.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor UserMethods and optimize
GetAttributesDescription
Get<PreserveReferenceHandler>()from UserMethods, replace with a constant display string, simplifying logic and slightly improving memory usage (one less call toWellKnownType.Get).GetAttributes<T>to get the symbols attributes before retrieving the attribute type. This way if the symbol doesn't have any attributes the symbol doesn't have to be retrieved.Checklist