-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add user implemented void mapping methods #569
Conversation
1d5acfd
to
ab46a5f
Compare
7b48907
to
0edb879
Compare
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
- Coverage 90.53% 90.46% -0.07%
==========================================
Files 173 175 +2
Lines 5956 6032 +76
Branches 756 762 +6
==========================================
+ Hits 5392 5457 +65
- Misses 398 404 +6
- Partials 166 171 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
873b388
to
65551df
Compare
65551df
to
3c631be
Compare
3c631be
to
938b14c
Compare
Should I update the docs under |
@TimothyMakkison I'll review the open PR's after 2.9.0 is released (we plan to release it next week). You can probably wait until the code / API changes are reviewed. If sth. fundamental changes after the review on the API surface, you then don't need to rewrite the docs again. |
src/Riok.Mapperly/Descriptors/MappingBodyBuilders/RuntimeTargetTypeMappingBodyBuilder.cs
Outdated
Show resolved
Hide resolved
...iok.Mapperly/Descriptors/Mappings/UserMappings/UserImplementedExistingTargetMethodMapping.cs
Outdated
Show resolved
Hide resolved
...iok.Mapperly/Descriptors/Mappings/UserMappings/UserImplementedExistingTargetMethodMapping.cs
Show resolved
Hide resolved
911f838
to
3b6eb39
Compare
Would it be worth making |
@TimothyMakkison feel free to create the issues. |
67f3016
to
c588462
Compare
16e3a6c
to
7efb65d
Compare
src/Riok.Mapperly/Descriptors/MappingBodyBuilders/RuntimeTargetTypeMappingBodyBuilder.cs
Outdated
Show resolved
Hide resolved
2 Nitpicks and rebasing, afterwards this can get merged 😊 |
7efb65d
to
77451d0
Compare
Thanks for the review, done the changes. 👍 I think it will be best to update the docs after all the other void mappings are completed |
🎉 This PR is included in version 3.1.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Let mapperly use user implemented existing target methods
Description
Add user implemented existing target mapping methods. Mapperly will attempt to use the users methods where possible
I can add support for reusing user defined void mappings, it should be a different PR.
Fixes #439
Checklist