fix: incorrect initialization for nullable nested memberpath unflattening #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect initialzation code for nested nullable members when unflattening
Description
When using
MapProperty
to map to deeply nested nullable members, Mapperly will generate a series of identical statements initializing the same field. This is because all theMemberNullAssignmentInitializerMapping
mistakenly use the sameIReadOnlyCollection
so will all update the same path.Added a
ToArray
toObjectPathNullableSubPaths
to collect the paths into separate collections.Example bug
Checklist