fix: resolve configuration enums directly to fix VS but crashing the source generator #654
Conversation
Codecov Report
@@ Coverage Diff @@
## main #654 +/- ##
==========================================
+ Coverage 90.94% 90.97% +0.03%
==========================================
Files 172 172
Lines 6142 6130 -12
Branches 782 780 -2
==========================================
- Hits 5586 5577 -9
+ Misses 378 377 -1
+ Partials 178 176 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Hopefully this will fix the issue. 👍
Unfortunately, even with the PR I still can't build or run the Samples project. I'm hoping this is an unrealated issue (happening for months with VS).
Build error on VS 17.6.2:
1>CSC : warning CS8032: An instance of analyzer Riok.Mapperly.MapperGenerator cannot be created from mapperly\src\Riok.Mapperly\bin\Debug\net7.0\Riok.Mapperly.dll : Could not load file or assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.. 1>mapperly\samples\Riok.Mapperly.Sample\CarMapper.cs(10,34,10,45): error CS8795: Partial method 'CarMapper.MapCarToDto(Car)' must have an implementation part because it has accessibility modifiers.
|
@TimothyMakkison this will fix it for users. I think rolling back d0eb471 will fix it for VS. It seems that VS cannot handle multi targeting source generators. I will revert to manual added polyfills in another PR. |
|
🎉 This PR is included in version 3.1.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #650