Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined portal #334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amitcnvrg
Copy link

make sure portal and ref exists before return

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (9ae16b6) to head (941f389).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          27       27           
  Lines        1037     1037           
  Branches      104      104           
=======================================
  Hits         1013     1013           
  Misses          9        9           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@P1robot
Copy link

P1robot commented Jan 24, 2020

Automated benchmark results (pass #0): passed

concurrency: 32
requests per second: 6160
concurrency: 128
requests per second: 7641
concurrency: 512
requests per second: 4685
concurrency: 1024
requests per second: 4006

@arkhamvm
Copy link

arkhamvm commented May 8, 2020

@riophae Hi. Can you accept this PR please?

@loeffel-io
Copy link

LETS GO! bug still exists since one year .. is the project dead?

@arkhamvm
Copy link

@riophae Please take a look at this PR 🙏

@abstrekt
Copy link

@riophae please accept the PR!

@micdobro
Copy link

@riophae Can you please accept the PR - this fix actually makes the project usable also in another setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants