Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Switch from gzip to XZ for archive compression #1606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmuellner
Copy link
Collaborator

To reduce the disk space consumption and upload/download times, let's switch to a better archrive compression algorithm. XZ should be popular enough to not cause many complaints about this.

To reduce the disk space consumption and upload/download times,
let's switch to a better archrive compression algorithm.
XZ should be popular enough to not cause many complaints about this.

Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
Copy link
Collaborator

@TommyMurphyTM1234 TommyMurphyTM1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments...

@@ -63,7 +63,7 @@ jobs:
sudo du -hs / 2> /dev/null || true

- name: tarball build
run: tar czvf riscv.tar.gz -C /opt/ riscv/
run: XZ_OPT="--threads=0 -6e" tar cJf riscv.tar.xz -C /opt/ riscv/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - how were the XZ_OPT options chosen?
Why --threads=0? Does "parallel" processing cause problems with the resulting output?
Isn't -6 compression level the default anyway so why specify it explicitly?

Could the XZ_OPT settings be specified once and reused elsewhere so that if they ever need to be tweaked it is just a single line change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants