Merge pull request #873 from eosea/bscan_tunnel_seg_fault_fix

Add null pointer check before right shift for bscan tunneling.
riscv-collab · Jun 29, 2023 · 92c0319 · 92c0319
2 parents 4be6a56 + 9d23d37
commit 92c0319
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/target/riscv/batch.c b/src/target/riscv/batch.c
@@ -115,8 +115,10 @@ int riscv_batch_run(struct riscv_batch *batch)
 
 	if (bscan_tunnel_ir_width != 0) {
 		/* need to right-shift "in" by one bit, because of clock skew between BSCAN TAP and DM TAP */
-		for (size_t i = 0; i < batch->used_scans; ++i)
-			buffer_shr((batch->fields + i)->in_value, DMI_SCAN_BUF_SIZE, 1);
+		for (size_t i = 0; i < batch->used_scans; ++i) {
+			if ((batch->fields + i)->in_value)
+				buffer_shr((batch->fields + i)->in_value, DMI_SCAN_BUF_SIZE, 1);
+		}
 	}
 
 	for (size_t i = 0; i < batch->used_scans; ++i)