Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with merge from upstream #1009

Closed
en-sc opened this issue Jan 29, 2024 · 3 comments
Closed

Issue with merge from upstream #1009

en-sc opened this issue Jan 29, 2024 · 3 comments
Assignees

Comments

@en-sc
Copy link
Collaborator

en-sc commented Jan 29, 2024

While merging #994, I've selected the wrong option of rebase and merge.
As I see it, there are 2 options:

  1. Merge these commits again as a part of the next merge from upstream (Merge up to 9659a9b5e28dc615dfb508d301fdd8fa426c191b from upstream #1008).
  2. Revert the commits (as a squashed revert) and merge again (Revert #994 "Merge up to b9f5262d42f00c563750bfacea97640cda9afbdc from upstream" #1007 is the revert).

I am leaning towards the first option, since this affects the list of commits in the merge, but not the diff.

@JanMatCodasip, @MarekVCodasip, I would like to know your opinion on the matter.

@en-sc en-sc self-assigned this Jan 29, 2024
@JanMatCodasip
Copy link
Collaborator

Hello @en-sc, the option 1 sounds fine to me, too. Thanks.

@MarekVCodasip
Copy link
Collaborator

First options seems ok to me.

@en-sc
Copy link
Collaborator Author

en-sc commented Feb 9, 2024

#1008 is merged. The issue is fixed.

@en-sc en-sc closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants