Revert "break from long loops on shutdown request" #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #1005. |
This reverts commits 2e920a2 and 8dbb125. The reason is, after `openocd_is_shutdown_pending()` becomes true, arbitrary command may be executed: * In `target_destroy()` and the corresponding `target->type->deinit_target()`. * In user-specifyed `pre_shutdown_commands` list. Change-Id: Icd00d1d954cd45e255880a6f76c3a74c098d6a17 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
en-sc
force-pushed
the
en-sc/break-ll-revert
branch
from
365b01e
to
41b5b54
Compare
|
Thank you for preparing the revert. I'd recommend to merge this on Monday if there is no other feedback by then. |
JanMatCodasip
approved these changes
Jan 26, 2024
MarekVCodasip
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commits 2e920a2 and 8dbb125.
The reason is, after
openocd_is_shutdown_pending()becomes true, arbitrary command may be executed:target_destroy()and the correspondingtarget->type->deinit_target().pre_shutdown_commandslist.Change-Id: Icd00d1d954cd45e255880a6f76c3a74c098d6a17