Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: set state and debug_reason in riscv_halt_go_all_harts() #1011

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

en-sc
Copy link
Collaborator

@en-sc en-sc commented Feb 2, 2024

If targets are in a halt group, and a target in the group reaches a breakpoint, the target's state was able to remain TARGET_RUNNING.

Addresses issue #1010

Change-Id: I734bc6da71d289c4d05b417c8bf67a7d1a56574f

…rts()`

If targets are in a halt group, and a target in the group reaches a
breakpoint, the target's state was able to remain `TARGET_RUNNING`.

Addresses issue riscv-collab#1010

Change-Id: I734bc6da71d289c4d05b417c8bf67a7d1a56574f
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
@aap-sc
Copy link
Collaborator

aap-sc commented Feb 7, 2024

LGTM

Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Let's merge on Monday (unless there are more comments).

@JanMatCodasip JanMatCodasip merged commit 5d4fa00 into riscv-collab:riscv Feb 12, 2024
4 checks passed
@en-sc en-sc deleted the en-sc/wa-halt-groups branch August 14, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants