Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv/program: Removed dead code for save/restore of registers #1012

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

JanMatCodasip
Copy link
Collaborator

Function riscv_program_exec() contains code for restoring of register values after progbuf execution. This code is not used anymore by current OpenOCD, and hence removed.

Related discussion can be found under:
#982

Change-Id: I4c79bec081522b6fc0d16367cef51ed19a131962

@JanMatCodasip JanMatCodasip changed the title riscv/program: Removed dead code for restoring register values riscv/program: Removed dead code for save/restore of registers Feb 5, 2024
en-sc
en-sc previously approved these changes Feb 6, 2024
Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I have only one minor suggestion.

src/target/riscv/program.h Outdated Show resolved Hide resolved
Function riscv_program_exec() contains code for restoring
of register values after progbuf execution. This code is
not used anymore by current OpenOCD, and hence removed.

Related discussion can be found under:
#982

Change-Id: I4c79bec081522b6fc0d16367cef51ed19a131962
Signed-off-by: Jan Matyas <jan.matyas@codasip.com>
Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanMatCodasip
Copy link
Collaborator Author

Let's merge on Thursday (unless further feedback comes).

@JanMatCodasip JanMatCodasip merged commit 2fc7360 into riscv Feb 9, 2024
5 checks passed
@JanMatCodasip JanMatCodasip deleted the remove-dead-code-riscv-program-exec branch February 9, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants