Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic cleanup of dm_*() calls in riscv-013.c #1013

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

JanMatCodasip
Copy link
Collaborator

Cleanup, non-functional changes:

  • Replaced one call of low-level function dm_op() by high-level dm_read().
  • Made sure that truncation of 64-bit values to 32 bits, when passed to dm_*, is explicit. (Added explicit casts.)

Change-Id: I1d1b2f29a822b6841373f3313de2b1e96f514116

Cleanup, non-functional changes:
- Replaced one call of low-level function dm_op()
  by high-level dm_read().
- Made sure that truncation of values passed to dm_*
  is explicit. (Added explicit casts.)

Change-Id: I1d1b2f29a822b6841373f3313de2b1e96f514116
Signed-off-by: Jan Matyas <jan.matyas@codasip.com>
Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanMatCodasip
Copy link
Collaborator Author

Let's merge on Thursday (unless any feedback comes).

@JanMatCodasip JanMatCodasip merged commit b7e7a03 into riscv Feb 9, 2024
5 checks passed
@JanMatCodasip JanMatCodasip deleted the dm-calls-cleanup branch February 9, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants