[NFC] target/riscv: refactor init_registers()
#1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-sc
force-pushed
the
en-sc/upstream-refactor-reg-acc
branch
4 times, most recently
from
0e20005
to
e936d33
Compare
|
Changed the PR to incorporate 33573cd |
MarekVCodasip
previously approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Looks good, thank you, this improves the readability a lot.
Quickly discussed with @JanMatCodasip too, who is in favor as well.
The logic in `init_registers()` was quite convoluted. Initialization of each `struct reg` field is separated into function `gdb_regno_<field_name>()`. IMHO, this makes it much easier to reason about the code. Change-Id: Id7faa1464ce026cc5025585d0a6a95a01fb39cee Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
en-sc
force-pushed
the
en-sc/upstream-refactor-reg-acc
branch
from
e936d33
to
ea7e174
Compare
|
@MarekVCodasip, there was a merge conflict with 33573cd, please, take a look. The resolution was to use the version from this commit, as planned (see a previous comment on the matter). |
MarekVCodasip
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in
init_registers()was quite convoluted. Initialization of eachstruct regfield is separated into functiongdb_regno_<field_name>().IMHO, this makes it much easier to reason about the code.
Change-Id: Id7faa1464ce026cc5025585d0a6a95a01fb39cee