Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: decode DMI scans in batch access #1025

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

en-sc
Copy link
Collaborator

@en-sc en-sc commented Mar 1, 2024

This allows to merge the implementation in batch.c with the one in riscv-013.c.

Change-Id: Ic3821a9ce2d75a7c6e618074679595ddefb14cfc

src/target/riscv/batch.h Outdated Show resolved Hide resolved
src/target/riscv/batch.h Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
JanMatCodasip
JanMatCodasip previously approved these changes Apr 19, 2024
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

(The last two small comments about data types can be resolved either now or in a follow-up PR, depending on your preference.)

src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
This allows to merge the implementation in `batch.c` with the one in
`riscv-013.c`.

Change-Id: Ic3821a9ce2d75a7c6e618074679595ddefb14cfc
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
@en-sc
Copy link
Collaborator Author

en-sc commented Apr 23, 2024

@JanMatCodasip, please, take a look again. I would like to merge this one.

Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@en-sc en-sc merged commit e51f869 into riscv-collab:riscv Apr 26, 2024
4 checks passed
@en-sc en-sc deleted the en-sc/dump-field branch April 26, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants