target/riscv: avoid unnecessary IR scans #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have checked the change in select_dmi() visually and it looks all right to me. It is equivalent to what majority (or all?) other targets do. I can see this PR is still marked as a draft. @en-sc, do you have any doubts about this one or any further testing that you'd like to carry out? (Also the PR needs to be rebased.) |
en-sc
force-pushed
the
en-sc/no-extra-ir
branch
from
ef53e0d
to
287839f
Compare
Change-Id: I03feb5c7d72d5aa38f2cc13c4ed30175cffde84a Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
en-sc
force-pushed
the
en-sc/no-extra-ir
branch
from
287839f
to
a96a0a4
Compare
en-sc
changed the title
|
@JanMatCodasip, I've tested the commit and it seems fine. Please, take a look. |
JanMatCodasip
approved these changes
Sep 9, 2024
|
This commit introduces an issue for targets with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.