Fix Checkpatch and Sparse tool warnings

[erhankur]

We have fixed several warnings in our fork. https://github.com/espressif/openocd-esp32

I would like to fix them also here. This will be helpful when/if you want to upstream your commits.

Additionally cherry-picked a commit from upstream to fix build errors on the Clang compiler.

Remaining Sparse warnings:
https://github.com/erhankur/riscv-openocd/actions/runs/5548680099/jobs/10131935209?pr=3#step:5:3064

Most of them can be fixed by adding ULL or LL to 64-bit macros inside encoding.h
I can fix them after getting your opinion.

[JanMatCodasip]

Thanks!

[timsifive]

I'm not a fan of all this non-functional churn, which will only generate more changes between riscv-openocd and upstream. But I guess it needs to be done, and I assume every change here is because a tool is enforcing that style now.

If it possible to make a github workflow that automatically runs Sparse, similar to how we currently run checkpatch?

[erhankur]

I'm not a fan of all this non-functional churn, which will only generate more changes between riscv-openocd and upstream. But I guess it needs to be done, and I assume every change here is because a tool is enforcing that style now.

If it possible to make a github workflow that automatically runs Sparse, similar to how we currently run checkpatch?

Yes possible. The easy way, just need a reference for the current head. It might be a counter or a log file that we can compare.
Another way, not easy, might be comparing git diff lines with the created log file.
We will make it for our fork. Also for the clang scan-build tool. Then I can come up here with another PR

[timsifive]

Looks like this PR now has a conflict.

[erhankur]

Looks like this PR now has a conflict.

Rebased and fixed.

[erhankur]

@timsifive can we merge this?