gdb_server,rtos: Differentiate rtos_get_gdb_reg failing and not imple… #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mented If it fails, then pass that failure on. If it's simply not implemented, then we can fall through and try target_get_gdb_reg_list_noread(). This difference matters when the target representing the current hwthread is unavailable, but the target that is linked to the gdb connection is available. In that case we want the operation to return an error to gdb, instead of reading the register from the target that is available. Change-Id: I9c84ca556f818c5580e25ab349a34a226fcf0f43 Signed-off-by: Tim Newsome <tim@sifive.com>
src/rtos/rtos.c
Outdated
| @@ -591,7 +591,7 @@ int rtos_get_gdb_reg(struct connection *connection, int reg_num) | |||
|
|
|||
| free(reg_list); | |||
| } | |||
| return ERROR_FAIL; | |||
| return ERROR_NOT_IMPLEMENTED; | |||
There was a problem hiding this comment.
Overall, this looks all right to me. I have just two suggestions:
-
Code style: For readability, I'd recommend to use here the early-return code structure, as shown below.
-
What should be returned at the very end of the function, that is if the
reg_numis not found inreg_list? I believe it should be ERROR_FAIL.
int rtos_get_gdb_reg(...)
{
if ( (!target->rtos) ||
current_threadid == -1 ||
current_threadid == 0 ||
/* ... */ ) {
/* early return */
return ERROR_NOT_IMPLEMENTED;
}
/* The rest of the algorithm continues here */
/* ... */
/* ... */
/* What should be returned if we reach the end? */
LOG_ERROR("Did not find register number %d in RTOS register list", reg_num);
return ERROR_FAIL;
/* or */
return ERROR_NOT_IMPLEMENTED;
}Exit early if conditions aren't satisfied, instead of putting the core code inside an if(). Also return ERROR_FAIL if conditions are satisfied but no matching registers were found. Change-Id: I77aa63d9f707bc38d1a71899275ba603914b52c9 Signed-off-by: Tim Newsome <tim@sifive.com>
JanMatCodasip
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mented
If it fails, then pass that failure on. If it's simply not implemented, then we can fall through and try target_get_gdb_reg_list_noread().
This difference matters when the target representing the current hwthread is unavailable, but the target that is linked to the gdb connection is available. In that case we want the operation to return an error to gdb, instead of reading the register from the target that is available.
Change-Id: I9c84ca556f818c5580e25ab349a34a226fcf0f43