Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/gdb_server: Fake resuming unavailable targets. #927

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

timsifive
Copy link
Collaborator

When asked to resume an unavailable target, resume any available targets and report success.

Change-Id: Ieafc63794c1a6eba8948c0f9ce84fa74f9765041

Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks overall fine to me - checked visually only.

I have several suggestions and questions.

src/server/gdb_server.c Outdated Show resolved Hide resolved
src/server/gdb_server.c Outdated Show resolved Hide resolved
src/server/gdb_server.c Show resolved Hide resolved
src/server/gdb_server.c Show resolved Hide resolved
When asked to resume an unavailable target, resume any available targets
and report success.

Change-Id: Ieafc63794c1a6eba8948c0f9ce84fa74f9765041
Signed-off-by: Tim Newsome <tim@sifive.com>
@timsifive timsifive merged commit c8b1d3c into riscv Oct 16, 2023
5 checks passed
@timsifive timsifive deleted the unavailable_resume branch October 16, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants