-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target: Update messages connected with examine
#931
target: Update messages connected with examine
#931
Conversation
Move `examine_attempted` flag to target struct to make it target specific. `Info` messages for retry and `Error` messages for failure added. Change-Id: Id2fbe7dc68d746c936c8412289d0d149fbd80d71 Signed-off-by: Kirill Radkin <kirill.radkin@syntacore.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK.
@kr-sc , @timsifive, unfortunately, this needs to be reverted. The implementation is buggy. We have
This function is called only once. From src/openocd.c. So, the original intention for the variable is just to mark that this function was called. I guess that this may result in subtle errors, since the condition for:
Will never be true for the targets that had a deferred examine. |
This reverts commit a3db93b. Reason for revert: riscv-collab#931 (comment)
Move
examine_attempted
flag to target struct to make it target specific.Info
messages for retry andError
messages for failure added.P.S. I have to request this patch here because of https://review.openocd.org/c/openocd/+/6964. There is no such patch in upstream openocd repo.