Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge up to 16e9b9c44fa62ea6eec99d1fb7bc43a8f1cc2f7e from upstream. #986

Merged
merged 51 commits into from
Jan 4, 2024

Commits on Nov 18, 2023

  1. target: Remove break/watchpoints in target_destroy()

    Break- and watchpoints are not removed when a target is destroyed
    which introduces a memory leak.
    
    Change-Id: I6143d48f7efd765b7752a12fdc337da3496d896f
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7956
    Reviewed-by: Marek Vrbka <marek.vrbka@codasip.com>
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    3862e07 View commit details
    Browse the repository at this point in the history
  2. doc: xtensa architecture clarifications/fixes

    - Fix Xtensa .cfg file references for NXP EVK
    - Add clarification note for "xtensa xtmem" command
    - Resolve TEX build warnings
    
    Signed-off-by: ianst <ianst@cadence.com>
    Change-Id: I0f2b56d0d084d86f557fadf3ac35fd04bf99650c
    Reviewed-on: https://review.openocd.org/c/openocd/+/7972
    Tested-by: jenkins
    Reviewed-by: Erhan Kurubas <erhan.kurubas@espressif.com>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    ianstcdns authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    9ebc2a6 View commit details
    Browse the repository at this point in the history
  3. xtensa: update XDM register map for TRAX support

    - Include additional debug module registers
    - Add translation function for DM reg addr -> ID
    - Add DM read/write commands
    
    Signed-off-by: ianst <ianst@cadence.com>
    Change-Id: If95419d24a9f27a40fa695c8c15326cdfd127ef1
    Reviewed-on: https://review.openocd.org/c/openocd/+/7973
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    ianstcdns authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    f8096ce View commit details
    Browse the repository at this point in the history
  4. breakpoints: Fix endless loop in bp/wp_clear_target

    If we can't remove bp/wp, we will stuck in endless loop
    
    Change-Id: I44c0a164db1d15c0a0637d33c75087a49cf5c0f4
    Signed-off-by: Kirill Radkin <kirill.radkin@syntacore.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7940
    Tested-by: jenkins
    Reviewed-by: Anatoly P <kupokupokupopo@gmail.com>
    Reviewed-by: Tim Newsome <tim@sifive.com>
    Reviewed-by: Jan Matyas <jan.matyas@codasip.com>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    kr-sc authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    7c60f65 View commit details
    Browse the repository at this point in the history
  5. breakpoints: Add target logging to breakpoints and watchpoints

    This patch adds target logging to breakpoint
    handling code. This makes it easier to
    debug multicore/multithread systems.
    
    Change-Id: I6bea8079a457070a8f63d0ce381a4ece6f5a190a
    Signed-off-by: Marek Vrbka <marek.vrbka@codasip.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7922
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    MarekVCodasip authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    851d1ad View commit details
    Browse the repository at this point in the history
  6. openocd: src/target: Correctly handle CCSIDR_EL1.Associativity=0

    Associativity=0 means that only one CMO is needed for all ways.
    It could also mean that the cache is 1-way, but this is less likely.
    
    Currently Associativity=0 causes us to hang in the while loop in
    decode_cache_reg. Fix it by skipping the loop in this case. We can let
    way_shift be set to the arbitrary value of 0 because in the case where
    Associativity=0 we only ever shift 0 by it before ORing it into the
    CMO operand.
    
    Change-Id: I7c1de68d33f6b3ed627cbb1e2401d43185e4c1e3
    Signed-off-by: Peter Collingbourne <pcc@google.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7916
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    pcc authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    ee96a95 View commit details
    Browse the repository at this point in the history
  7. aarch64: Use 64-bit reads/writes to access SCTLR_EL1

    We were previously inadvertently clearing the top 32 bits of SCTLR_EL1
    during read_memory/write_memory as a result of using 32-bit operations
    to access the register and because the fields used to temporarily
    store the register were 32-bit. Fix it.
    
    Change-Id: I657d7f949e1f7ab6bf90609e3f91cae09cade31a
    Signed-off-by: Peter Collingbourne <pcc@google.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7939
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    pcc authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    393da81 View commit details
    Browse the repository at this point in the history
  8. contrib/firmware: remove unnecessary delay commands in the i2c bit-ba…

    …nging implementation
    
    Change-Id: I741244be7a1bf186cfcb66a5b93e2a1a2ab0fde5
    Signed-off-by: Ahmed BOUDJELIDA <aboudjelida@nanoxplore.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7809
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Ahmed BOUDJELIDA authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    8bf7f60 View commit details
    Browse the repository at this point in the history
  9. contrib/firmware: extend the number of bytes to be sent in the i2c bi…

    …t-banging read operation
    
    Change-Id: Iaeb3d5ba37da1bd77d36ad0ebbc6b45c46860dec
    Signed-off-by: Ahmed BOUDJELIDA <aboudjelida@nanoxplore.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7810
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Ahmed BOUDJELIDA authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    a69a4e2 View commit details
    Browse the repository at this point in the history
  10. contrib/firmware: add 'send not acknowledged' function to the i2c bit…

    …-banging implementation
    
    Change-Id: I60597ebc126da4acb00654513b96f52261253e12
    Signed-off-by: Ahmed BOUDJELIDA <aboudjelida@nanoxplore.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7811
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Ahmed BOUDJELIDA authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    bb27677 View commit details
    Browse the repository at this point in the history
  11. jtag/drivers/cmsis-dap: Restructure commands

    Use a command group 'cmsis-dap' with subcommands instead of individual
    commands with 'cmsis_dap_' prefix.
    
    The old commands are still available to ensure backwards compatibility,
    but are marked as deprecated.
    
    Change-Id: I75facb7572a86354c2ce6144aa7fadf3b5a6db4e
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7963
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    Reviewed-by: Bohdan Tymkiv <bohdan200@gmail.com>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    b25e532 View commit details
    Browse the repository at this point in the history
  12. jtag/drivers/cmsis-dap: Return error in 'backend' command

    Change-Id: Ib9bf7ab50cbe193e9e726efb3cb58e53723a6dd1
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7964
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    ba79d50 View commit details
    Browse the repository at this point in the history
  13. drivers/cmsis_dap: drop unused variable

    The variable 'mode' was introduced in
    commit 4dc8cd2 ("cmsis-dap: add initial cmsis-dap support")
    but never has been used (just cleared)
    
    Change-Id: Ia741d181ee8006bd0d872f3358a57e045235741a
    Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7965
    Reviewed-by: zapb <dev@zapb.de>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    tom-van authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    1c9f4ac View commit details
    Browse the repository at this point in the history
  14. jtag/drivers/kitprog: Restructure commands

    Use a command group 'kitprog' with subcommands instead of individual
    commands with 'kitprog_' prefix.
    
    The old command is still available to ensure backwards compatibility,
    but is marked as deprecated.
    
    Change-Id: I7f0d447939819ffc488a3d7a8de672b58887127f
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7967
    Reviewed-by: Bohdan Tymkiv <bohdan200@gmail.com>
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    f55b122 View commit details
    Browse the repository at this point in the history
  15. mips32: MIPS32_OP_SRL was using SRA opcode.

    The mips opcode macro for the SRL opcode was using the wrong constant
    value:
    
    SRA -- Shift right arithmetic
    Encoding: 0000 00-- ---t tttt dddd dhhh hh00 0011
    
    SRL -- Shift right logical
    Encoding: 0000 00-- ---t tttt dddd dhhh hh00 0010
    
    This corrects the opcode constant for SRL and adds the SRA opcode for
    completeness.
    
    There is only one user of MIPS32_OP_SRL in src/flash/nor/cfi.c:
    Since the mask constant (0x00000080 for the DQ7 mask) shifted in this
    case would never have the sign bit set, it worked fine even though it
    was accidentally using the SRA opcode instead of SRL.
    
    Change-Id: I0a80746e2075c7df1ce35b9db00d9d0b997a3feb
    Signed-off-by: Tobias Diedrich <ranma+openocd@tdiedrich.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/3613
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-by: Oleksij Rempel <linux@rempel-privat.de>
    Tobias Diedrich authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    62b526d View commit details
    Browse the repository at this point in the history
  16. jtag/drivers/jlink: Use correct command errors

    While at it, remove the syntax error messages as the correct
    syntax is already suggested due to the return value used.
    
    Change-Id: I9310ba96ed3f8a85c37cee9193e481ad3df02e77
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7969
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    a23c69d View commit details
    Browse the repository at this point in the history
  17. jtag/drivers/ftdi: Use correct command error

    Change-Id: I625acdd8a226528de86f113582e31755d679e68e
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7970
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    acc1717 View commit details
    Browse the repository at this point in the history
  18. jtag/drivers/jtag_vpi: Remove redundant error messages

    The correct syntax is already suggested due to the return
    value used.
    
    Change-Id: I971a579014c1eaf13b1932f7fa87c020a8eba69c
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7971
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    dc0f79d View commit details
    Browse the repository at this point in the history
  19. jtag/drivers/rshim: Remove redundant error message

    The correct syntax is already suggested due to the return
    value used.
    
    Change-Id: I0f4a7f93fdf056e7517c754d6d4ecd7928f1d226
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7992
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    1df35d9 View commit details
    Browse the repository at this point in the history
  20. flash/nor/stm32f2x: Remove redundant error messages

    The correct syntax is already suggested due to the return
    value used.
    
    While at it, apply some minor code improvements.
    
    Change-Id: I676e2ebf5714c850a436854a32c2e9d2f181d537
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7999
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    738f1e1 View commit details
    Browse the repository at this point in the history
  21. flash/nor/stm32h7x: Remove redundant error messages

    The correct syntax is already suggested due to the return
    value used.
    
    While at it, apply some minor code improvements.
    
    Change-Id: Idf3d7a46ddecd70823e06bc3997f41fcdb8e501f
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8000
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    b310b3b View commit details
    Browse the repository at this point in the history
  22. flash/nor/stm32l4x: Remove redundant error messages

    The correct syntax is already suggested due to the return
    value used.
    
    While at it, apply some minor code improvements.
    
    Change-Id: Id32440cdd531077008abd679add32246c4249eb2
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8001
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    ea07b3c View commit details
    Browse the repository at this point in the history
  23. flash/nor/pic32mx: Remove redundant error message

    The correct syntax is already suggested due to the return
    value used.
    
    While at it, apply some minor code improvements.
    
    Change-Id: I990c0f7a0871f4b1a0fcdd13afc190149302443c
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8003
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    4e5b009 View commit details
    Browse the repository at this point in the history
  24. flash/nor/stmqspi: Use correct command errors

    Change-Id: I796b4e350653117bf63d18ad274a1d3d3d1337db
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8004
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    8ccd782 View commit details
    Browse the repository at this point in the history
  25. rtt/tcl: Fix line indentation

    Change-Id: I21f8084ca648cfe35f8f4dba078b2227772578a8
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7993
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    acde409 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. rtt_server: Add option for a message when client connects

    This is useful when using the SEGGER RTT tooling, as the SEGGER RTT
    tool J-Link RTT Viewer version 7.84f requires that it receives a
    messages immediately after connecting. Otherwise it will give a timeout
    and it will not connect.
    
    Change-Id: I9240a1b6a93cd5c0fbd18292afb33b89013d78bf
    Signed-off-by: Thiemo van Engelen <tvanengelen@victronenergy.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7752
    Tested-by: jenkins
    Reviewed-by: zapb <dev@zapb.de>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    ThiemoVanEngelen authored and borneoa committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    53e67c3 View commit details
    Browse the repository at this point in the history
  2. target: remove target_number

    Change-Id: Id36e5ad2967303483392fd2670630289ecde2553
    Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7998
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-by: Marek Vrbka <marek.vrbka@codasip.com>
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    en-sc authored and borneoa committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    be5cfdc View commit details
    Browse the repository at this point in the history
  3. target: Throw error in 'debug_reason' command

    Instead of returning an 'error string', throw an error. This makes it
    much easier to handle errors in Tcl scripts or in tools that use Tcl RPC.
    
    Change-Id: I75c48750cfad7430fa5e6bc88fe04ebd59d34cea
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8006
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    1b0b07b View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. tcl/target/gd32vf103: work around broken ndmreset

    On this chip, the ndmreset bit in the RISC-V debug module doesn't
    trigger a system reset like it should. To work around this, add a custom
    "reset-assert" handler in its config file that resets the system by
    writing to memory-mapped registers.
    
    I've tested this workaround on a Sipeed Longan Nano dev board with a
    GD32VF103CBT6 chip. It works correctly for both "reset run" and "reset
    halt" (halting at pc=0 for the latter).
    
    I originally submitted[1] this workaround to the riscv-openocd fork of
    OpenOCD. That fork's maintainers accepted it, but have not upstreamed it
    like they have several other of my changes.
    
    [1] #538
    
    Change-Id: I7482990755b300fcbe4963c9a599d599bc02684d
    Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
    Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-on: https://review.openocd.org/c/openocd/+/6957
    Tested-by: jenkins
    Reviewed-by: zapb <dev@zapb.de>
    tchebb authored and tom-van committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7ac389c View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. target/mips32: pracc write cp0 status register first

    When user requested a change on cp0 status register,
    it may contain changes on EXL/ERL bits, and changes on
    these bits could lead to differnt behaviours on writing
    to other cp0 registers.
    
    Change-Id: Ic83039988c29c06ee134226b52de943c46d19da2
    Signed-off-by: Walter Ji <walter.ji@oss.cipunited.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7914
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    709924470 authored and borneoa committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    15038ab View commit details
    Browse the repository at this point in the history
  2. target: clarify usage of coreid

    By definition in `target/target.h`, `coreid` is not a unique identifier
    of a target -- it can be the same for targets on different TAPs.
    
    Change-Id: Ifce78da55fffe28dd8b6b06ecae7d8c4e305c0a2
    Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7997
    Tested-by: jenkins
    Reviewed-by: Marek Vrbka <marek.vrbka@codasip.com>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    en-sc authored and borneoa committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    73d62f3 View commit details
    Browse the repository at this point in the history
  3. target/target: Fix 'wp' command usage

    While at it, fix the 'wp' command documentation.
    
    Change-Id: I70f3110e8ce286051f8f810260f1857b2285e634
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8022
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-by: Jan Matyas <jan.matyas@codasip.com>
    zapb-0 authored and borneoa committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    119a533 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. remote_bitbang: Add SWD support

    This adds new command characters to make SWD work with the new split
    jtag and swd operations of bitbang.
    
    The command characters are as follows:
        O - SWDIO drive 1
        o - SWDIO drive 0
        c - SWDIO read request
        d - SWD write 0 0
        e - SWD write 0 1
        f - SWD write 1 0
        g - SWD write 1 1
    
    Documentation has been updated accordingly. The new commands will be
    used by an adapted version of the jtag-openocd applet of the "Glasgow
    Debug Tool" (https://github.com/glasgowEmbedded/Glasgow). It has been
    tested against an stm32f103 and an at91samd21 target.
    
    contrib/remote/bitbang/remote_bitbang_sysfsgpio.c has also been adapted
    to support SWD via the new command set. Some limited testing has been
    done using a Raspberry Pi 2 with an stm32f103 and an at91samd21 target
    attached.
    
    Change-Id: I8e998a2cb36905142cb16e534483094cd99e8fa7
    Signed-off-by: Manuel Wick <manuel@matronix.de>
    Signed-off-by: David Ryskalczyk <david.rysk@gmail.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/6044
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    mwick83 authored and tom-van committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    0f70c6c View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. jtag/drivers/cmsis_dap_bulk: use asynchronous libusb transfer

    The synchronous libusb_bulk_transfer() always waits
    for the transfer to complete. Therefore it does not allow issuing
    multiple USB requests as used on HID backend.
    
    Switch to asynchrounous libusb_submit_transfer().
    
    With this patch a good USB FS based CMSIS-DAPv2 adapter
    almost doubles the throughput:
    
     adapter speed: 20000 kHz
     poll off
    
     > load_image /run/user/1000/ram256k.bin 0x20000000
     262144 bytes written at address 0x20000000
     downloaded 262144 bytes in 0.428576s (597.327 KiB/s)
    
     > dump_image /dev/null 0x20000000 0x40000
     dumped 262144 bytes in 0.572875s (446.869 KiB/s)
    
    Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
    Change-Id: Ic6168ea4eca4f6bd1d8ad541a07a8d70427cc509
    Reviewed-on: https://review.openocd.org/c/openocd/+/7365
    Reviewed-by: zapb <dev@zapb.de>
    Tested-by: jenkins
    tom-van committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    fd75e9e View commit details
    Browse the repository at this point in the history
  2. jtag/drivers/cmsis_dap: implement canceling of pending USB requests

    Use it whenever an out-of-sync response is detected to clean
    USB bulk transfer state.
    
    USB hidapi does not offer any means to cancel a pending request,
    therefore cmsis_dap_hid_cancel_all() does nothing.
    
    Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
    Change-Id: Ie36fa760c1643ae10be0e87fc633068965a72242
    Reviewed-on: https://review.openocd.org/c/openocd/+/7366
    Tested-by: jenkins
    Reviewed-by: zapb <dev@zapb.de>
    tom-van committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    66391d2 View commit details
    Browse the repository at this point in the history
  3. drivers/cmsis_dap: use quirk workarounds optionally

    Introduce 'cmsis-dap quirk' command to enable and
    disable quirk mode.
    
    If enabled, disconnect and connect before a switch
    sequence and do not use multiple packets pipelining.
    
    Change-Id: I6576f7de9f6c98a25c3cf9eec9a456a23610d00d
    Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7966
    Tested-by: jenkins
    tom-van committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ba16fdc View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. target/espressif: add algorithm support to execute code on target

    This functionality can be useful for;
    1-ESP flashing code to load flasher stub on target and
    write/read/erase flash.
    2-ESP GCOV command uses some of these functions to run
    onboard routines to dump coverage info.
    
    This is high level api for the Espressif xtensa and riscv targets
    
    Signed-off-by: Erhan Kurubas <erhan.kurubas@espressif.com>
    Change-Id: I5e618b960bb6566ee618d4ba261f51af97a7cb0e
    Reviewed-on: https://review.openocd.org/c/openocd/+/7759
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    erhankur authored and borneoa committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d3ffcc7 View commit details
    Browse the repository at this point in the history
  2. target/xtensa: add algorithm support

    Add arch level functions to execute code on the target
    
    Signed-off-by: Erhan Kurubas <erhan.kurubas@espressif.com>
    Change-Id: I089095de6fcb9906ad8c84232fa52a77db5e6185
    Reviewed-on: https://review.openocd.org/c/openocd/+/7771
    Tested-by: jenkins
    Reviewed-by: Ian Thompson <ianst@cadence.com>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    erhankur authored and borneoa committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d06d8ea View commit details
    Browse the repository at this point in the history
  3. target/espressif: add algorithm support to xtensa chips

    Also includes esp_xtensa flasher stub jumper binary.
    
    Signed-off-by: Erhan Kurubas <erhan.kurubas@espressif.com>
    Change-Id: I054ce31033ca6a87afe9b5325b545338a7d8fe8f
    Reviewed-on: https://review.openocd.org/c/openocd/+/7772
    Tested-by: jenkins
    Reviewed-by: Ian Thompson <ianst@cadence.com>
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    erhankur authored and borneoa committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    4003762 View commit details
    Browse the repository at this point in the history
  4. target: Add some info messages about examination process.

    These messages helps to clarify current status of examination process
    
    Change-Id: I5d93903c4680deed2c1bf707d8f7ef0b48ffdc9a
    Signed-off-by: Kirill Radkin <kirill.radkin@syntacore.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8013
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    kr-sc authored and borneoa committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    0ce08ec View commit details
    Browse the repository at this point in the history
  5. target: Increase maximum profile sample count to 1000000

    Change-Id: I38276dd1af011ce5781b0264b7cbb08c31a0a2ad
    Signed-off-by: Paul Reimer <paul@zaber.com>
    Signed-off-by: Karl Palsson <karlp@tweak.au>
    Reviewed-on: https://review.openocd.org/c/openocd/+/6099
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    karlp authored and borneoa committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    2bd40b0 View commit details
    Browse the repository at this point in the history
  6. tcl/target/at91sama5d2.cfg: allow choice of SWD instead of JTAG

    The target supports both SWD and JTAG, but the existing cfg file
    only supports JTAG.  Using the standard [using_jtag] mechanism,
    the user would now have a choice.
    
    Change-Id: Ic6adb68090422812d591f6bf5b945ac10f323c74
    Signed-off-by: Peter Lawrence <majbthrd@gmail.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8020
    Reviewed-by: Jörg Wunsch <openocd@uriah.heep.sax.de>
    Reviewed-by: Paul Fertser <fercerpav@gmail.com>
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    majbthrd authored and borneoa committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    5f6b25a View commit details
    Browse the repository at this point in the history
  7. HACKING: fix how to retrieve hooks/commit-msg

    Probably due to new version of gerrit, the download of the gerrit
    hooks via scp is not working anymore.
    Also the instructions available, after login, in
    	https://review.openocd.org/admin/repos/openocd,general
    report that the hook file has to be downloaded via https also when
    the user want to use ssh for gerrit access.
    
    Drop scp in the suggestions to download the hook file and keep
    https download only.
    
    Change-Id: I0c8e5bb61ed8c7423a42a0d5d92866e071a814bb
    Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reported-by: Rolf Nooteboom <rolf@Onethinx.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8034
    Tested-by: jenkins
    Reviewed-by: Paul Fertser <fercerpav@gmail.com>
    borneoa committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    c1ae95f View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. cmsis_dap_usb_hid: improve detection of probes with unusual report sizes

    Currently all Atmel CMSIS-DAP interfaces are assumed to have 512 byte
    reports except for the mEDBG (found on Xplained Mini boards) and the nEDBG
    (found on Curiosity Nano boards). This check is far from exaustive and it
    results in some Microchip programmers (like the MPLAB Snap and PICkit 4)
    not working correctly with OpenOCD.
    
    Instead of assuming that Atmel programmers have 512 byte reports unless we
    know otherwise, this commit flips the logic around. Only the older "third
    generation" EDBG based programmers have 512 byte report sizes, and that 64
    bytes will be more common in Microchip tools going forward.
    
    The list of PIDs for 3rd generation Microchip programmers comes from
    toolinfo.py from Microchip's pyedbglib.
    
    This commit adds a more generic "quirks" list that will allow programmers
    with unusual report sizes to be added easily in the future.
    
    Change-Id: Ic39a4bdcd67c4c93d5707657c6ee5d216bc4437a
    Signed-off-by: Samuel Dewan <samdewan@me.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8033
    Tested-by: jenkins
    Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
    samueldewan authored and tom-van committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3413ae6 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. target: use bool for backup_working_area

    The field backup_working_area is always used as a boolean value.
    
    Use bool type for backup_working_area.
    
    Change-Id: I55c68d717dbbe9e5caf60fd1db368527c6d1b995
    Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8036
    Tested-by: jenkins
    Reviewed-by: zapb <dev@zapb.de>
    borneoa committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    49348f1 View commit details
    Browse the repository at this point in the history
  2. helper: nvp: minor fixes

    Fix incorrect reference for original file.
    Fix copy-paste example.
    
    Change-Id: I1ea7909ca241611122f93ca11a4c94c97674b430
    Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8037
    Tested-by: jenkins
    Reviewed-by: Henrik Nordström <henrik.nordstrom@addiva.se>
    borneoa committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    d3d287b View commit details
    Browse the repository at this point in the history
  3. jtag: Rename 'hasidcode' to 'has_idcode'

    While at it, fix some coding style issues.
    
    Change-Id: I8196045f46ce043ed0d28cb95470132b3a7de1bb
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8039
    Tested-by: jenkins
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    zapb-0 authored and borneoa committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    f018cd7 View commit details
    Browse the repository at this point in the history
  4. jtag/core: Use 'bool' data type for 'bypass'

    Change-Id: I918fd5ce674e808ad6a96634a11046d2b3f6a05c
    Signed-off-by: Marc Schink <dev@zapb.de>
    Reviewed-on: https://review.openocd.org/c/openocd/+/8040
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    zapb-0 authored and borneoa committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    d2b34b4 View commit details
    Browse the repository at this point in the history
  5. doc/usb_adapters: add dumps of two versions of Atmel EDBG

    USB HS based CMSIS-DAP v1 (HID) adapters found
    on Atmel/Microchip Xplained Pro development boards.
    
    Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
    Change-Id: I62a4b656dc6dce27da386e906d87088befc2bcbf
    Reviewed-on: https://review.openocd.org/c/openocd/+/8038
    Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
    Tested-by: jenkins
    tom-van authored and borneoa committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    16e9b9c View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Merge commit '16e9b9c44fa62ea6eec99d1fb7bc43a8f1cc2f7e' into from_ups…

    …tream
    
    Conflicts:
    	configure.ac
    	tcl/target/gd32vf103.cfg
    
    Change-Id: I72bbb973249b7bbfa720696fa2c76a87a41a2e9c
    timsifive committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    e4a0658 View commit details
    Browse the repository at this point in the history
  2. Fix build.

    Change-Id: I4dd4a3bac0586bfaeb0ae9c197b637d6edb422c9
    Signed-off-by: Tim Newsome <tim@sifive.com>
    timsifive committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    a7b5b32 View commit details
    Browse the repository at this point in the history