target/riscv: fix addressing in dm_read/dm_write
#991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-sc
force-pushed
the
en-sc/dm-dmi-address-conversion
branch
2 times, most recently
from
f43fd8d
to
96d569d
Compare
JanMatCodasip
changed the title
dm_read/dm_wirtedm_read/dm_write
JanMatCodasip
previously approved these changes
Jan 16, 2024
There was an error in `dm_read`/`dm_write`: DMI address was checked against DM registers disregarding DM base address. To solve the issue `dmi_address()` function was introduced. Change-Id: Ia3be619417b5f5b53db5dfe302db05170d6787c9 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
en-sc
force-pushed
the
en-sc/dm-dmi-address-conversion
branch
from
96d569d
to
bb4c117
Compare
JanMatCodasip
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in
dm_read/dm_write: DMI address was checked against DM registers disregarding DM base address.To solve the issue
dmi_address()function was introduced.Change-Id: Ia3be619417b5f5b53db5dfe302db05170d6787c9