UB in negate in mulh/mulhsu #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibrunieAtSi5
commented
Dec 21, 2023
aswaterman
approved these changes
Dec 21, 2023
|
@nibrunieAtSi5 Returning to this eight months later, can you rebase onto master and then squash the commits together? |
nibrunie
force-pushed
the
patch-2
branch
2 times, most recently
from
6ddf910 to
fefc853
Compare
|
@jerryz123 could you review this PR since you reviewed #1539 ? compiler link to reproduce the possible UB before this PR: https://godbolt.org/z/bn9xh3G1s (using |
Ensuring No negation on -2^63(int64_t) is performed during mulh/mulhsu Signed-off-by: Nicolas Brunie <82109999+nibrunieAtSi5@users.noreply.github.com> Update riscv/arith.h Signed-off-by: Nicolas Brunie <82109999+nibrunieAtSi5@users.noreply.github.com>
jerryz123
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1539.
Ensuring No negation on -2^63(int64_t) is performed during mulh/mulhsu