vfloat sequencing #221
Open
vfloat sequencing #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prior to merge needs UopGen refactor |
| "vsaddu.vv" : {"pipe" : "vfixed", "uop_gen" : "ARITH", "latency" : 1}, | ||
| "vsaddu.vx" : {"pipe" : "vfixed", "uop_gen" : "ARITH", "latency" : 1}, | ||
| "vsaddu.vi" : {"pipe" : "vfixed", "uop_gen" : "ARITH", "latency" : 1}, | ||
| "vsaddu.vv" : {"pipe" : "vint", "uop_gen" : "ARITH", "latency" : 1}, |
There was a problem hiding this comment.
Why did you get rid of the vfixed unit?
| "vfrsub.vf" : {"pipe" : "vfloat", "uop_gen" : "ARITH", "latency" : 6}, | ||
|
|
||
| # Vector Floating-Point Instructions: Vector Widening Floating-Point Add/Subtract Instructions | ||
| "vfwadd.vv" : {"pipe" : "vfloat", "uop_gen" : "ARITH", "latency" : 6}, |
There was a problem hiding this comment.
These instructions have wide dests so they should use ARITH_WIDE_DEST.
| "vfnmsub.vf" : {"pipe" : "vfloat", "uop_gen" : "ARITH", "latency" : 6}, | ||
|
|
||
| # Vector Floating-Point Instructions: Vector Widening Floating-Point Fused Multiply-Add Instructions | ||
| "vfwmacc.vv" : {"pipe" : "vfloat", "uop_gen" : "ARITH", "latency" : 6}, |
There was a problem hiding this comment.
These should use the ARITH_MAC which adds the destination of each uop as a source.
|
@orion160 the uop generators for the vector floating point instructions need to be reviewed. I would also add a new execution unit for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.