refactor mstatus handler function #652
Open
+112
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotorinMinami
changed the title
Timmmm
requested changes
Jan 2, 2025
KotorinMinami
force-pushed
the
reflect_mstatus
branch
2 times, most recently
from
8c3ba10 to
0953d93
Compare
|
@Timmmm Is there anything else that needs improvement in my code? |
Timmmm
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM - would be nice to get a second opinion though. Any takers @arichardson @jordancarlin etc?
arichardson
approved these changes
Jan 9, 2025
Timmmm
added
the
will be merged
jordancarlin
approved these changes
Jan 13, 2025
KotorinMinami
force-pushed
the
reflect_mstatus
branch
from
0953d93 to
8633212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #639, and there are also some legitimacy issues in legalize_mstatus, so this PR is intended to help make corrections