Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2 fixes, for using batched ptensorlayers #14

Merged
merged 13 commits into from
Nov 5, 2024
Merged

Conversation

InnocentBug
Copy link
Collaborator

No description provided.

Copy link
Owner

@risi-kondor risi-kondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the equality of subgraphs, this works but what I had in mind was a cascade where we first check if the two subgraph objects are the same, if not, check if they point to the same ptens_base.subgraph, if not then call the operator== method of the underlying ptens::Subgraph.

@InnocentBug
Copy link
Collaborator Author

For the equality of subgraphs, this works but what I had in mind was a cascade where we first check if the two subgraph objects are the same, if not, check if they point to the same ptens_base.subgraph, if not then call the operator== method of the underlying ptens::Subgraph.

Sure, I can add that cascade as well.

@InnocentBug
Copy link
Collaborator Author

For the equality of subgraphs, this works but what I had in mind was a cascade where we first check if the two subgraph objects are the same, if not, check if they point to the same ptens_base.subgraph, if not then call the operator== method of the underlying ptens::Subgraph.

Sure, I can add that cascade as well.

done

@risi-kondor risi-kondor merged commit d1607b4 into dev5 Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants