Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support license key #116

Merged
merged 2 commits into from
Sep 6, 2024
Merged

feat: support license key #116

merged 2 commits into from
Sep 6, 2024

Conversation

arkbriar
Copy link
Collaborator

@arkbriar arkbriar commented Sep 5, 2024

License key support.

Signed-off-by: arkbriar <arkbriar@gmail.com>
@arkbriar arkbriar requested a review from a team as a code owner September 5, 2024 07:37
## @section license. Enterprise license key configuration for RisingWave enterprise.
##

license:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Collaborator Author

@arkbriar arkbriar Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the license block, not license key block. I think the key field below stands for licenseKey. Making it licenseKey sounds like one can set the key directly to the field, but it's not true.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@arkbriar arkbriar added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit e466e0b Sep 6, 2024
1 check passed
@arkbriar arkbriar deleted the shunjie/license-key branch September 6, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants