Skip to content

Commit

Permalink
fix: wrong connection string for local disk object store (#604)
Browse files Browse the repository at this point in the history
* fix: wrong connection string for local disk object store

After risingwavelabs/risingwave#13915, local disk path is no longer hard coded, which exposes this bug.

* fix: ut
  • Loading branch information
wjf3121 authored Feb 19, 2024
1 parent 5c2f41d commit d4739eb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/factory/risingwave_object_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func (f *RisingWaveObjectFactory) hummockConnectionStr() string {
return fmt.Sprintf("hummock+webhdfs://%s@%s", webhdfs.NameNode, webhdfs.Root)
case f.isStateStoreLocalDisk():
localDisk := stateStore.LocalDisk
return fmt.Sprintf("hummock+fs://@%s", localDisk.Root)
return fmt.Sprintf("hummock+fs://%s", localDisk.Root)
case f.isStateStoreHuaweiCloudOBS():
return fmt.Sprintf("hummock+obs://%s", stateStore.HuaweiCloudOBS.Bucket)
default:
Expand Down
2 changes: 1 addition & 1 deletion pkg/factory/risingwave_object_factory_testcases_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3433,7 +3433,7 @@ func stateStoreTestCases() map[string]stateStoresTestCase {
},
envs: []corev1.EnvVar{{
Name: "RW_STATE_STORE",
Value: "hummock+fs://@root",
Value: "hummock+fs://root",
}},
},
"huawei-cloud-obs": {
Expand Down

0 comments on commit d4739eb

Please sign in to comment.