feat: full kubernetes addr #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 67.67% 67.69% +0.01%
==========================================
Files 27 27
Lines 4210 4228 +18
==========================================
+ Hits 2849 2862 +13
- Misses 1312 1316 +4
- Partials 49 50 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
arkbriar
reviewed
Aug 4, 2023
Comment on lines
189
to
192
| // TODO according to @arkbriar, update compute advertise-addr may cause compatibility issue | ||
| if component == consts.ComponentCompute { | ||
| return componentName | ||
| } |
There was a problem hiding this comment.
It's okay since the default value of isFullKubernetesAddr is false.
There was a problem hiding this comment.
Just remove this if-block and let the users know that enableFullKubernetesAddr will cause incompatibility.
arkbriar
approved these changes
Aug 4, 2023
Gogomoe
force-pushed
the
chuan/feat_full_addr
branch
from
dc5e5c6
to
ac22a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Now the address of components (e.g. meta. compute) is
[<pod>.]<service>.This pr add a flag
EnableFullKubernetesAddrin RisingWave CRD. If's enabled, operator will use a full k8s address ([<pod>.]<service>.<namespace>.svc) instead.It's useful if we need to call
risectlat another namespace. (risectluses the meta advertise address to connect meta. In the previous address format, the connection cannot be established in a different namespace.)Tested it locally.
Checklist
Refer to a related PR or issue link (optional)