Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set startup probe to prevent from unnecessary restarts #490

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

arkbriar
Copy link
Collaborator

@arkbriar arkbriar commented Aug 7, 2023

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • As title. Using startup probe can prevent pods from restarting when meta isn't fully initialized. It helps bootstrapping a RisingWave cluster more smoothly.
  • Note that this is a change that will affect existing clusters: after any kind of manifest operations, all RisingWave pods will get recreated.

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: arkbriar <arkbriar@gmail.com>
@arkbriar arkbriar added the enhancement New feature or request label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #490 (a9b978c) into main (5bd9701) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   67.67%   67.74%   +0.07%     
==========================================
  Files          27       27              
  Lines        4210     4220      +10     
==========================================
+ Hits         2849     2859      +10     
  Misses       1312     1312              
  Partials       49       49              
Flag Coverage Δ
unittests 67.74% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/factory/risingwave_object_factory.go 89.63% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Gogomoe Gogomoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkbriar arkbriar added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit 30bd7f8 Aug 7, 2023
6 of 7 checks passed
@arkbriar arkbriar deleted the feat/startup-probe branch August 7, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants