feat: support license

[fuyufjh]

What's changed and what's your intention?

To use a license, users need to

1. store the license (JWT Token) in K8s Secret with key license
2. set the RisingWave CRD .license.secretName to the secret name

Checklist

• I have written the necessary docs and comments
• I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

• Tracking: license manager and feature tiers risingwave#17446
• feat: introduce license manager and feature tiers risingwave#17396

[fuyufjh]

@arkbriar make generate-all it will make such a diff. Is it expected or did I did anything wrong?

[arkbriar]

@arkbriar make generate-all it will make such a diff. Is it expected or did I did anything wrong?

Could you try remove the local bin dir and try again?

[BugenZhao]

The kernel uses the term of license_key and accepts env var of RW_LICENSE_KEY to initialize the system parameter. Shall we unify the terms here?

[arkbriar]

Mark it a required field.

Suggested change

	SecretName string `json:"secretName,omitempty"`
	SecretName string `json:"secretName"`

[arkbriar]

Please also clarify the secret key that will be used.

[fuyufjh]

Mark it a required field.

Can you explain the motivation? I learned from

risingwave-operator/apis/risingwave/v1alpha1/risingwave_ssl.go

Line 22 in f7e5e79

SecretName string `json:"secretName,omitempty"`

[arkbriar]

It probably makes the semantic more clear. The example you quoted seems untuned 😄

Currently,

# valid but has no effect
spec:
  license:
    secretName: ""

# valid and effective
spec:
  license:
    secretName: "abc"

# valid and won't be misunderstood
spec:
  # no license field

After change, the k8s API service will reject

# no longer valid
spec:
  license:
    secretName: ""

[fuyufjh]

Either LGTM, but I'd like to keep it consistent with TLS config (RisingWaveTLSConfiguration). Do you think we need to change it as well?

[BugenZhao]

Suggested change

	const RisingWaveLicenseLicenseSecretKey = "licenseKey"
	const RisingWaveLicenseKeySecretKey = "licenseKey"

? 🤔

[codecov]

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 55.03%. Comparing base (c6da95a) to head (25ffc48).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
apis/risingwave/v1alpha1/zz_generated.deepcopy.go	0.00%	13 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
+ Coverage   55.01%   55.03%   +0.01%     
==========================================
  Files          40       40              
  Lines        6645     6679      +34     
==========================================
+ Hits         3656     3676      +20     
- Misses       2864     2877      +13     
- Partials      125      126       +1     

Flag	Coverage Δ
unittests	55.03% <58.82%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arkbriar]

LGTM!