Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove all etcd related tests and add tests for postgres #738

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

arkbriar
Copy link
Collaborator

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • As title.

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: arkbriar <arkbriar@gmail.com>
@arkbriar arkbriar requested a review from wjf3121 October 22, 2024 06:18
@arkbriar arkbriar requested a review from a team as a code owner October 22, 2024 06:18
@arkbriar arkbriar force-pushed the shunjie/update-to-use-postgresql-in-the-first-place branch from 9cae524 to c46963e Compare October 22, 2024 06:19
@arkbriar arkbriar requested a review from cyliu0 October 22, 2024 06:20
wjf3121
wjf3121 previously approved these changes Oct 23, 2024
Copy link
Contributor

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjf3121 wjf3121 dismissed their stale review October 23, 2024 05:41

Buildkite seems failing.

Signed-off-by: arkbriar <arkbriar@gmail.com>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.42%. Comparing base (4830b2f) to head (f22513c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   55.42%   55.42%           
=======================================
  Files          40       40           
  Lines        6759     6759           
=======================================
  Hits         3746     3746           
  Misses       2886     2886           
  Partials      127      127           
Flag Coverage Δ
unittests 55.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkbriar arkbriar added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 5b37360 Oct 23, 2024
9 of 10 checks passed
@arkbriar arkbriar deleted the shunjie/update-to-use-postgresql-in-the-first-place branch October 23, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants