Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): support emit on window close in parentheses (DBT) #16592

Closed
fuyufjh opened this issue May 6, 2024 · 2 comments
Closed

feat(parser): support emit on window close in parentheses (DBT) #16592

fuyufjh opened this issue May 6, 2024 · 2 comments
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented May 6, 2024

Is your feature request related to a problem? Please describe.

Currently we parse emit on window close as part of the create statement rather than select . As a result, queries like create materialized view ... as ( ... emit on window close ) can't be accepted because the parentheses explicitly include emit on window close as part of select.

The parentheses were added by dbt to wrap any materialized view query. Thus, this problem affect all DBT users.

Describe the solution you'd like

Is it possible to modify the parser to work around this?

Describe alternatives you've considered

No response

Additional context

No response

@github-actions github-actions bot added this to the release-1.9 milestone May 6, 2024
@fuyufjh
Copy link
Member Author

fuyufjh commented May 14, 2024

@chenzl25 Is it possible to fix this by modifying the DBT risingwave plugin?

@fuyufjh fuyufjh modified the milestones: release-1.9, release-1.10 May 14, 2024
@fuyufjh fuyufjh changed the title feat(parser): support emit on window close in parentheses feat(parser): support emit on window close in parentheses (DBT) May 15, 2024
@chenzl25
Copy link
Contributor

Yes. I had fixed this problem in DBT. risingwavelabs/dbt-risingwave#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants