Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default tags to [] in the database #46

Closed
bgentry opened this issue Nov 20, 2023 · 2 comments · Fixed by #53
Closed

Default tags to [] in the database #46

bgentry opened this issue Nov 20, 2023 · 2 comments · Fixed by #53
Assignees
@bgentry
Labels
needs db migration Fixing this issue would require a new database migration

Comments

@bgentry
Copy link
Contributor

bgentry commented Nov 20, 2023

From #44 (comment):

The other strong contender here is to make tags NOT NULL and DEFAULT [] in the database, so it becomes always not-nil and an empty array on any job row that comes back.
@bgentry bgentry self-assigned this Nov 20, 2023
@bgentry bgentry added the needs db migration Fixing this issue would require a new database migration label Nov 21, 2023
@bgentry
Copy link
Contributor Author

bgentry commented Nov 21, 2023

@brandur thought about this more today and realized now that we've shipped this would require a new DB migration to be added. Maybe we want to hold off and batch it together with other such changes?

@brandur
Copy link
Contributor

brandur commented Nov 21, 2023

@bgentry Only other option is to YOLO and have a policy that first day installs are going to need a remigrate. TBH, I think that's okay personally, but has to be done fast.

bgentry added a commit that referenced this issue Nov 21, 2023
@bgentry
Default tags to an empty slice, make not null
2d34163 
Fixes #46.
@bgentry bgentry mentioned this issue Nov 21, 2023
Merged
bgentry added a commit that referenced this issue Nov 21, 2023
@bgentry
Default tags to an empty slice, make not null
5bc4ebf 
Fixes #46.
bgentry added a commit that referenced this issue Nov 22, 2023
@bgentry
Default tags to an empty slice, make not null
58d108e 
This adds a new migration v3 to adjust the tags column to ensure it's
never null, which helps simplify client implementations by not making
them deal with both null and empty array values.

Fixes #46.
bgentry added a commit that referenced this issue Nov 22, 2023
@bgentry
Default tags to an empty slice, make not null
bdce0f6 
This adds a new migration v3 to adjust the tags column to ensure it's
never null, which helps simplify client implementations by not making
them deal with both null and empty array values.

Fixes #46.
bgentry added a commit that referenced this issue Nov 22, 2023
@bgentry
Default tags to an empty slice, make not null (#53)
c5bd949 
This adds a new migration v3 to adjust the tags column to ensure it's
never null, which helps simplify client implementations by not making
them deal with both null and empty array values.

Fixes #46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgentry bgentry

Labels
needs db migration Fixing this issue would require a new database migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default tags to an empty slice, make not null riverqueue/river
2 participants
@brandur @bgentry