Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump comments in the unique job example #12

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Nov 12, 2023

An incredibly trivial change to bump a few comments in the unique job
example in accordance to how they're written in our documentation. I
realized one of the comments implied that the job would be worked
exactly once which isn't a guarantee that we can actually make. Say that
insertion will be skipped instead.

@brandur brandur requested a review from bgentry November 12, 2023 19:15
An incredibly trivial change to bump a few comments in the unique job
example in accordance to how they're written in our documentation. I
realized one of the comments implied that the job would be worked
exactly once which isn't a guarantee that we can actually make. Say that
insertion will be skipped instead.
@bgentry bgentry enabled auto-merge (squash) November 12, 2023 21:49
@bgentry bgentry merged commit 713bdb4 into master Nov 12, 2023
5 checks passed
@bgentry bgentry deleted the brandur-bump-example-comment branch November 12, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants