Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to riverpgxv5@v0.0.1 #22

Merged
merged 2 commits into from
Nov 13, 2023
Merged

pin to riverpgxv5@v0.0.1 #22

merged 2 commits into from
Nov 13, 2023

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Nov 13, 2023

To make this work, also set up a replace directive to use the local riverpgxv5 from within the river package's go.mod.

I tested this locally from our riverdemo test app and confirmed that I was able to import riverpgxv5@v0.0.1, and then even tested with a locally tagged river@v0.0.2 and was able to use that at the same time.

The gomoddirectives linter does not allow any replace directives by default, but we can customize that to allow this one replace if you think this seems sane.

To make this work, also set up a replace directive to use the local
riverpgxv5 from within the river package's go.mod.
@bgentry bgentry requested a review from brandur November 13, 2023 16:06
@bgentry
Copy link
Contributor Author

bgentry commented Nov 13, 2023

You would think I would be able to use the replace-allow-list option, but no, that still fails due to the local replace path. So I just have to allow all local replaces afaict.

Copy link
Contributor

@brandur brandur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it looks sane?

I was trying to read what the effect of a replace was on other projects that might be importing River. The Go Modules reference says this:

replace directives only apply in the main module’s go.mod file and are ignored in other modules. See Minimal version selection for details.

I think that means it won't affect anything else? But as usual with Go documentation, the wording is too vague/ambiguous to say anything for sure.

@bgentry bgentry merged commit ec7ff85 into master Nov 13, 2023
5 checks passed
@bgentry bgentry deleted the bg-bump-river-driver-import branch November 13, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants