Update indirect dependencies from update-mod-version script
#540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is driven by [1] and the same bug we'd noticed in another project previously too. Until now, `update-mod-version` hadn't been updating versions on indirect dependencies, and `rivershared` in the CLI had been indirect, thereby causing it to try and resolve v0.11.2 instead of v0.11.3. Here, update the script so that indirect dependencies are updated as well. [1] #538
brandur
force-pushed
the
brandur-update-indirect
branch
from
8f5924f
to
d623f19
Compare
bgentry
approved these changes
Aug 20, 2024
|
ty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is driven by [1] and the same bug we'd noticed in another project
previously too. Until now,
update-mod-versionhadn't been updatingversions on indirect dependencies, and
riversharedin the CLI had beenindirect, thereby causing it to try and resolve v0.11.2 instead of
v0.11.3.
Here, update the script so that indirect dependencies are updated as
well.
[1] #538