Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to golangci-lint 1.60.1 #548

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Commits on Aug 22, 2024

  1. Upgrade to golangci-lint 1.60.1

    Here, take the project to golangci-lint 1.60.1, which is now widely
    available on Homebrew and elsewhere. It comes with a number of breaking
    changes, so I figure it's not the worst idea to keep us on latest so
    that future upgrades are less painful.
    
    All breakages are related to overflow checking in `gosec` getting more
    strict. The strictness is kind of useful in that it reminds us to check
    bounds with something like `min(limit, math.MaxInt32)`, but it can't
    detect that a bounds check is done with `min(...)`, which is kind of
    annoying because it means you need a `nolint` tag on all of these.
    brandur committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9258553 View commit details
    Browse the repository at this point in the history