Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set state if running query bug #560

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix set state if running query bug #560

merged 1 commit into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. also clear unique_key when should_cancel 

    While doing some work on a related query, I noticed that the
`unique_key` is being cleared here specifically if the new state is
explicitly `cancelled`, but _not_ if the state is being set to cancel
because of a cancellation attempt that didn't get picked up before the
job completed.

I didn't yet add test coverage for this but wanted to at least commit it
before I forgot.
    @bgentry
    bgentry committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    11c3b12 View commit details
    Browse the repository at this point in the history