Move check on zero workers from client constructor to Start
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
approved these changes
Dec 2, 2023
This one's in pursuit of trying to solve #87, where it's difficult to inject a River client into a worker because trying to initialize a client with the workers bundle empty is an error, creating a chicken and egg problem. There's no real reason to disallow a zero worker bundle from the constructor, and in fact a lot of our tests already add additional workers after the client was originally initialized (although `newTestClient` injects a default worker, which is why there's no error). If it's a useful pattern for us, it's probably useful for other users too. Here, move the zero workers check from the constructor over to the `Start` function instead. While it seems okay to initialize a client without workers, starting it without any does seem like a potential problem that we'd want to keep an eye out for. Fixes #87.
brandur
force-pushed
the
brandur-move-zero-workers-check-to-start
branch
from
015ee53
to
89fa9f3
Compare
|
Thanks! Also added a changelog. |
|
Awesome change, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's in pursuit of trying to solve #87, where it's difficult to
inject a River client into a worker because trying to initialize a
client with the workers bundle empty is an error, creating a chicken and
egg problem.
There's no real reason to disallow a zero worker bundle from the
constructor, and in fact a lot of our tests already add additional
workers after the client was originally initialized (although
newTestClientinjects a default worker, which is why there's noerror). If it's a useful pattern for us, it's probably useful for other
users too.
Here, move the zero workers check from the constructor over to the
Startfunction instead. While it seems okay to initialize a clientwithout workers, starting it without any does seem like a potential
problem that we'd want to keep an eye out for.
Fixes #87.