Documentation fix for the UniqueOpts.ByState parameter
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-unique-opts-docs-fix
branch
from
b6eda48
to
67ff7ca
Compare
A few weeks back we ended up changing the default set of states for the `UniqueOpts.ByState` property -- previously, it hadn't included completed jobs, but it was changed so that it did. I thought I'd fixed the documentation as I was bringing that in, but apparently I forgot. Here, update the Godoc for `UniqueOpts.ByState` to also include completed jobs.
brandur
force-pushed
the
brandur-unique-opts-docs-fix
branch
from
67ff7ca
to
a530282
Compare
bgentry
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks back we ended up changing the default set of states for the
UniqueOpts.ByStateproperty -- previously, it hadn't included completedjobs, but it was changed so that it did.
I thought I'd fixed the documentation as I was bringing that in, but
apparently I forgot. Here, update the Godoc for
UniqueOpts.ByStatetoalso include completed jobs.