Make typing on UniqueOpts.by_state true JobState enums instead of strings
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strings Make the typing on `UniqueOpts.by_state` strong by making it a list of `JobState` enums instead of a list of strings. Change usages in the test suite over to enums instead of strings.
brandur
force-pushed
the
brandur-unique-job-state
branch
from
82c2dcd
to
c5a6aab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the typing on
UniqueOpts.by_statestrong by making it a list ofJobStateenums instead of a list of strings. Change usages in the testsuite over to enums instead of strings.