-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(captcha): captcha guard and module #576
Open
ABCxFF
wants to merge
1
commit into
main
Choose a base branch
from
09-06-captcha-module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+633
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
NathanFlurry
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the logic is incorrect for captchas. captchas are supposed to require a captcha on the first request.
- this module needs better doc comments about all of the scripts.
- the scripts are missing description.
- the module is missing an icon & tags & description.
- don't commit the deno.lock. this might be an issue with the toolchain.
- make sure to run rivet module format and rivet module lint
NathanFlurry
requested changes
Sep 27, 2024
ABCxFF
force-pushed
the
09-06-captcha-module
branch
from
September 27, 2024 15:28
677ac6c
to
9bac358
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ABCxFF
force-pushed
the
09-06-captcha-module
branch
3 times, most recently
from
September 29, 2024 15:38
dedc11c
to
0ac3358
Compare
This was referenced Sep 29, 2024
ABCxFF
force-pushed
the
09-06-captcha-module
branch
from
October 16, 2024 19:42
0ac3358
to
e5161d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.