Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lobbies.list_regions): return regions sorted by proximity to client #581

Open
wants to merge 1 commit into
base: 09-12-captcha-on-lobbies-api
Choose a base branch
from
Open

feat(lobbies.list_regions): return regions sorted by proximity to client #581

wants to merge 1 commit into from
+109 −9

Conversation

ABCxFF
Copy link
Collaborator

@ABCxFF ABCxFF commented Sep 19, 2024

No description provided.

@ABCxFF Graphite App
Copy link
Collaborator Author

ABCxFF commented Sep 19, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 19, 2024
Open
Open
@NathanFlurry NathanFlurry force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from 95c4c16 to ef94b9c Compare September 27, 2024 07:57
NathanFlurry

This comment was marked as duplicate.

Sign in to view

@NathanFlurry NathanFlurry marked this pull request as ready for review September 27, 2024 08:27
NathanFlurry
NathanFlurry requested changes Sep 27, 2024
View reviewed changes
modules/lobbies/utils/rivet/geo_coord.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/rivet/geo_coord.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/rivet/geo_coord.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/rivet/geo_coord.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/rivet/geo_coord.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/rivet/geo_coord.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/region.ts Show resolved Hide resolved
modules/lobbies/utils/region.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/region.ts Outdated Show resolved Hide resolved
modules/lobbies/utils/region.ts Outdated Show resolved Hide resolved
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from ef94b9c to 2eb8ffa Compare September 27, 2024 14:15
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from 2eb8ffa to c83cc7c Compare September 27, 2024 14:21
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from c83cc7c to 45d6e7b Compare September 27, 2024 15:28
This was referenced Sep 27, 2024
Open
Closed
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from 45d6e7b to 5af8683 Compare September 27, 2024 16:54
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from 5af8683 to 11edc0a Compare September 27, 2024 16:58
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch 2 times, most recently from 4cb93d6 to e48b989 Compare September 27, 2024 17:30
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from e48b989 to 729aca4 Compare September 29, 2024 15:38
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch 3 times, most recently from 811094f to 05e2458 Compare September 29, 2024 16:01
@ABCxFF ABCxFF mentioned this pull request Sep 29, 2024
Open
@ABCxFF ABCxFF mentioned this pull request Sep 29, 2024
Open
@ABCxFF ABCxFF force-pushed the 09-12-captcha-on-lobbies-api branch from 411dc9c to 0a6f5d3 Compare October 16, 2024 19:42
@ABCxFF ABCxFF force-pushed the 09-19-feat_lobbies.list_regions_return_regions_sorted_by_proximity_to_client branch from 05e2458 to 1f8d48a Compare October 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABCxFF @NathanFlurry