Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module invariants file does not store homology dimension #117

Open
delooper opened this issue Jun 7, 2018 · 2 comments
Open

module invariants file does not store homology dimension #117

delooper opened this issue Jun 7, 2018 · 2 comments

Comments

@delooper
Copy link

delooper commented Jun 7, 2018

If you save an output file from rivet_console, then load it in the RIVET GUI, it presents the computation as if it is a 0-dimensional homology computation, regardless of the dimension computed in rivet_console. i.e. the line at the bottom that describes the dimension always says "0".

I imagine either the dimension is not stored in rivet_console's output, or perhaps the GUI does not read it properly. This is more of an expositional problem, rather than a bug, but it can lead to confusion.

@mlesnick
Copy link
Contributor

mlesnick commented Jun 9, 2018

To add to this, in our pull request, some RIVET files (namely those constructed from
'firep' input) may not have a homology dimension at all, and homology dimension should be "N/A."

In fact, for firep input files the bottom of the main window also shows homology dimension 0 when it should show N/A, though the file input dialogue does already show N/A.

@mlesnick
Copy link
Contributor

mlesnick commented Jun 9, 2018

@xoltar, would the RIVET serialization need to be changed at all to address these issues?

@mlesnick mlesnick changed the title rivet_console output does not store dimension rivet_console output does not store homology dimension Dec 11, 2019
@mlesnick mlesnick changed the title rivet_console output does not store homology dimension module invariants file does not store homology dimension Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants