Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis labels have been added #146

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

cklotte
Copy link

@cklotte cklotte commented Jul 12, 2019

Axis labels for both x-bins and y-bins were added, including tick marks for all of the axis labels.

Note on a thing to fix: When you configure the font size to very large, the 'density' label gets pushed out of the diagram, while the 'distance' label doesn't.

The next thing to do would be to implement a convention to determine the precision of which the labels are rounded to.

@mlwright84
Copy link
Contributor

These axis labels are a nice improvement to the RIVET visualization! Overall, I like this a lot. However, I see a few issues that I would like to see improved before we merge this pull request.

  1. If the user increases the font size, then the axis labels may extend outside of the viewable region, like this:
    RIVET_GUI_1
    This problem might have existed before the changes in this pull request, but it makes sense to fix it now.

  2. If the user adjusts the window bounds using the top/bottom/left/right selectors, the max and/or min value isn't labeled in the window, even if there is enough space for the label. See the following example:
    RIVET_GUI_2

  3. The numbers are sometimes printed incorrectly, as in the following example:
    RIVET_GUI_3
    Here, the printed labels don't agree with the coordinates that appear in the popup boxes when the mouse is hovered over the green and red dots. This was produced with the file data/Test_Point_Clouds/circle_data_240pts_codensity.txt, using 20 bins in each direction. Note that the smallest and largest bins in each direction are correct. For example, the lowest x-bin is 5.25, and the largest x-bin is 48.

cklotte added 4 commits July 16, 2019 16:26
…-axis label down a little, added half-sized tick marks for the labels that don't have numbers, got rid of datalistx and datalisty as they were not necessary, and other bug fixes
… the previous commit, there were qDebugs and commented out code that wasn't deleted before commiting. I deleted them in this commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants