Compiled/ExpandAllBranches Resolve AllOf Schemas #3764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When using pre compiled schemas with large allOf's mixed with if/thens, the if's will never be resolved to a single schema because of no form data. This causes
mergeAllOf
to always throw an errorcould not merge subschemas in allOf:
and makes the schema compiling very slow. This fix will just return the allOf sub schemas to be resolved without trying to merge them together.Checklist
npm run test:update
to update snapshots, if needed.