fix: fixing the merging of anyOf/oneOf schemas #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
approved these changes
Jul 14, 2023
Improved the merging of anyOf/oneOf schemas using the `mergeSchemas()` function instead of object structuring - In `@rjsf/utils` improved the merging of anyOf/oneOf schemas as follows: - Updated `getDefaultFormState()` and `retrieveSchema()` functions to use `mergeSchemas()` - In `@rjsf/core`, updated `MultiSchemaField` to use `mergeSchemas()` - Updated the tests accordingly, adding new tests as needed - Updated the `CHANGELOG.md` accordingly
heath-freenome
force-pushed
the
fix-oneof-anyof-merging
branch
from
f1d10b8
to
5f3fbf4
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Improved the merging of anyOf/oneOf schemas using the
mergeSchemas()function instead of object structuring@rjsf/utilsimproved the merging of anyOf/oneOf schemas as follows:getDefaultFormState()andretrieveSchema()functions to usemergeSchemas()@rjsf/core, updatedMultiSchemaFieldto usemergeSchemas()CHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.