fix: Fixed 3757 by supporting extraErrors that block the submit #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix rjsf-team#3757 by adding a new `extraErrorsBlockSubmit` prop on `Form` - Updated the `FormProps` and `Form` for the new `extraErrorsBlockSubmit` flag - Updated the validation code to detect when the flag is set and there are `extraErrors` and allow the extra error to be focused on - Updated `form-props` documentation with additional details about `extraErrors` as well as the new prop - Updated the `CHANGELOG.md` file accordingly switching from a patch to minor release due to the new feature
nickgros
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fix #3757 by adding a new
extraErrorsBlockSubmitprop onFormFormPropsandFormfor the newextraErrorsBlockSubmitflagextraErrorsand allow the extra error to be focused onform-propsdocumentation with additional details aboutextraErrorsas well as the new propCHANGELOG.mdfile accordingly switching from a patch to minor release due to the new featureChecklist
npm run test:updateto update snapshots, if needed.